ACK: [F][PATCH 1/1] net/bpfilter: remove superfluous testing message

Colin Ian King colin.king at canonical.com
Tue Apr 7 08:23:28 UTC 2020


On 07/04/2020 09:13, Thomas Lamprecht wrote:
> From: Bruno Meneguele <bmeneg at redhat.com>
> 
> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
> usage for /dev/kmsg") but should've been deleted before patch submission.
> Although it doesn't cause any harm to the code or functionality itself, it's
> totally unpleasant to have it displayed on every loop iteration with no real
> use case. Thus remove it unconditionally.
> 
> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
> Signed-off-by: Bruno Meneguele <bmeneg at redhat.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  net/bpfilter/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
> index efea4874743e..05e1cfc1e5cd 100644
> --- a/net/bpfilter/main.c
> +++ b/net/bpfilter/main.c
> @@ -35,7 +35,6 @@ static void loop(void)
>  		struct mbox_reply reply;
>  		int n;
>  
> -		fprintf(debug_f, "testing the buffer\n");
>  		n = read(0, &req, sizeof(req));
>  		if (n != sizeof(req)) {
>  			fprintf(debug_f, "invalid request %d\n", n);
> 

Yep, reducing spamming the log is always good. Thanks!

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the kernel-team mailing list