[Acked/CMT] [Unstable][PATCH 0/6] Add support for ZFS debug symbols

[Mauricio Faria de Oliveira]

On Thu, Sep 26, 2019 at 1:06 PM Seth Forshee <seth.forshee at canonical.com> wrote:
>
> On Thu, Sep 26, 2019 at 12:17:48PM -0300, Mauricio Faria de Oliveira wrote:
> > On Thu, Sep 26, 2019 at 12:12 PM Andy Whitcroft <apw at canonical.com> wrote:
> > >
> > > On Wed, Aug 28, 2019 at 09:25:58AM -0300, Mauricio Faria de Oliveira wrote:
> > > > BugLink: https://bugs.launchpad.net/bugs/1840704
> > > >
> > > > The ZFS kernel modules aren't built with debug symbols,
> > > > which introduces problems/issues for debugging/support.
> > > >
> > > > Patches are required in:
> > > >
> > > > 1) linux kernel packaging, to add infrastructure to
> > > >    enable/build/strip/package debug symbols on DKMS.
> > > >    (this is sufficient with zfs-linux now in Eoan.)
> > > >
> > > > 2) zfs-linux and spl-linux, for the stable releases,
> > > >    which need a few patches to enable debug symbols
> > > >    (add option './configure --enable-debuginfo' and
> > > >    '(ZFS|SPL)_DKMS_ENABLE_DEBUGINFO' to dkms.conf.)
> > > >
> > > > Initially submitting the kernel patchset for Unstable,
> > > > for review/feedback.  It backports nicely into B/D/E,
> > > > should it be accepted; for X (doesn't use DKMS builds)
> > > > a simpler patch for the moment (until it does) works.
> > > >
> > > > The zfs/spl-linux patches are ready, to be submitted
> > > > once the approach used by the kernel package settles.
> > > >
> > > > Mauricio Faria de Oliveira (6):
> > > >   UBUNTU: [Debian]: Remove hardcoded $(pkgdir) in debug symbols handling
> > > >   UBUNTU: [Debian]: Handle debug symbols for modules in extras too
> > > >   UBUNTU: [Debian]: Check/link modules with debug symbols after DKMS
> > > >     modules
> > > >   UBUNTU: [Debian]: Warn about modules without debug symbols
> > > >   UBUNTU: [Debian]: dkms-build: new parameter for debug package
> > > >     directory
> > > >   UBUNTU: [Debian]: dkms-build: zfs: support for debug symbols
> > > >
> > > >  debian/rules.d/2-binary-arch.mk             | 50 ++++++++++++---------
> > > >  debian/scripts/dkms-build                   | 44 +++++++++++++++++-
> > > >  debian/scripts/dkms-build--nvidia-N         |  5 ++-
> > > >  debian/scripts/dkms-build--virtualbox-guest |  5 ++-
> > > >  4 files changed, 78 insertions(+), 26 deletions(-)
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > >
> > > > --
> > > > kernel-team mailing list
> > > > kernel-team at lists.ubuntu.com
> > > > https://lists.ubuntu.com/mailman/listinfo/kernel-team
> > >
> > > Other than the rather vile zfs specific additions which I think we would
> > > prefer to have as a callout helper like the postinstall one, it all
> > > looks fine.
> > >
> > > Acked-by: Andy Whitcroft <apw at canonical.com>
> > >
> >
> > Thanks for reviewing.
> >
> > Yes, I completely agree the zfs specific addition on PATCH 6/6 isn't great.
> >
> > I guess your ACK means it's OK to address this on another patch
> > instead of a PATCH v2 series?
>
> I was just playing with it, and am test building a patch to use a
> callout helper right now. Once I have it working I'll apply it along
> with your series.
>

Cool, thanks Seth!

> Thanks,
> Seth



-- 
Mauricio Faria de Oliveira