ACK/Cmnt: [Disco][SRU][PATCH 0/5] xfrm interface fixes

Stefan Bader stefan.bader at
Thu Sep 26 08:48:00 UTC 2019

On 25.09.19 18:29, Connor Kuehl wrote:
> BugLink:
> [Impact]
> Upstream has recently received a number of bug fixes that resolve kernel panics,
> memory leaks, and list handling for virtual xfrm interfaces that were debuted in
> 4.19.
> [Test Case]
> 3 of the 5 patches have test cases in their commit message for reproducing the
> fault they address.
> Another patch prevents including a stale name in the log files.
> And the other patch that doesn't have an explicit test case improves list
> handling.
> [Regression Potential]
> This patchset contains a nontrivial amount of changes. However, the heavier
> patches contain test cases that they resolve the regressions they were created
> for. They've been upstream since July and I don't see any follow up Fixes
> commits targeting these. The blast radius is "only" the xfrm interface but this
> is smoke tested and if any dependents rely on it for core functionality they
> might exercise it and would possibly notice any issues by now as well.
> Nicolas Dichtel (5):
>   xfrm interface: fix memory leak on creation
>   xfrm interface: avoid corruption on changelink
>   xfrm interface: ifname may be wrong in logs
>   xfrm interface: fix list corruption for x-netns
>   xfrm interface: fix management of phydev
>  include/net/xfrm.h        |   2 -
>  net/xfrm/xfrm_interface.c | 136 ++++++++++++--------------------------
>  2 files changed, 44 insertions(+), 94 deletions(-)
Limited scope to the xfrm interface and all cherry picks. Together with
successful testing it looks to be a reasonable batch.

Acked-by: Stefan Bader <stefan.bader at>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the kernel-team mailing list