ACK: [SRU][Bionic][PATCH 0/5] TC filters are broken on Mellanox after upstream stable updates (LP: #1842502)

Connor Kuehl connor.kuehl at canonical.com
Wed Sep 25 18:31:49 UTC 2019


On 9/25/19 1:07 AM, Juerg Haefliger wrote:
> [Impact]
> 
> Mellanox TC filters don't work for some key rules after the Bionic 4.15 stable patchset 2019-07-12 update (LP: #1836426). The offending commit is ("net/mlx5e: Set vlan masks for all offloaded TC rules").
> 
> This causes fatal network connectivity issues for projects that use the Mellanox ConnectX 5 NIC.
> 
> [Test Case]
> 
> TBD.
> 
> [Fix]
> 
> Backport the following upstream commit (which fixes the offending commit) and its prerequisites:
> d3a80bb5a3ea ("net/mlx5e: Don't match on vlan non-existence if ethertype is wildcarded")
> 
> [Regression Potential]
> 
> Low. Changes are isolated and limited to the mlx5_core driver and all commits are in upstream stable v4.19.y.
> 
> [Original description]
> 
> The following upstream fix was missing from the latest upstream stable update (LP: # and LP1839376: #1839213):
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d3a80bb5a3eac311ddf28387402593977574460d
> 
> Or Gerlitz (4):
>    net/mlx5e: Properly order min inline mode setup while parsing TC
>      matches
>    net/mlx5e: Get the required HW match level while parsing TC flow
>      matches
>    net/mlx5e: Always use the match level enum when parsing TC rule match
>    net/mlx5e: Don't match on vlan non-existence if ethertype is
>      wildcarded
> 
> Saeed Mahameed (1):
>    net/mlx5e: Remove redundant vport context vlan update
> 
>   .../net/ethernet/mellanox/mlx5/core/en_fs.c   |   1 -
>   .../net/ethernet/mellanox/mlx5/core/en_tc.c   | 146 ++++++++++--------
>   .../net/ethernet/mellanox/mlx5/core/eswitch.h |   7 +
>   3 files changed, 92 insertions(+), 62 deletions(-)
> 

Acked-by: Connor Kuehl <connor.kuehl at canonical.com>



More information about the kernel-team mailing list