[Disco][SRU][PATCH 0/5] xfrm interface fixes

Connor Kuehl connor.kuehl at canonical.com
Wed Sep 25 16:29:02 UTC 2019


BugLink: https://bugs.launchpad.net/bugs/1836261

[Impact]

Upstream has recently received a number of bug fixes that resolve kernel panics,
memory leaks, and list handling for virtual xfrm interfaces that were debuted in
4.19.

[Test Case]

3 of the 5 patches have test cases in their commit message for reproducing the
fault they address.

Another patch prevents including a stale name in the log files.

And the other patch that doesn't have an explicit test case improves list
handling.

[Regression Potential]

This patchset contains a nontrivial amount of changes. However, the heavier
patches contain test cases that they resolve the regressions they were created
for. They've been upstream since July and I don't see any follow up Fixes
commits targeting these. The blast radius is "only" the xfrm interface but this
is smoke tested and if any dependents rely on it for core functionality they
might exercise it and would possibly notice any issues by now as well.

Nicolas Dichtel (5):
  xfrm interface: fix memory leak on creation
  xfrm interface: avoid corruption on changelink
  xfrm interface: ifname may be wrong in logs
  xfrm interface: fix list corruption for x-netns
  xfrm interface: fix management of phydev

 include/net/xfrm.h        |   2 -
 net/xfrm/xfrm_interface.c | 136 ++++++++++++--------------------------
 2 files changed, 44 insertions(+), 94 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list