ACK/cmt: [SRU][EOAN/unstable][PATCH 0/1] alsa/sof: Enable SOF_HDA link and codec

[Seth Forshee]

On Mon, Oct 21, 2019 at 04:06:15PM -0500, Seth Forshee wrote:
> On Thu, Oct 17, 2019 at 08:28:49PM +0800, Hui Wang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1848490
> > 
> > So far, only OEM-B-OSP1, EOAN and later kernels have the alsa/sof driver,
> > and the OEM-B-OSP1 kernel already enabled these CONFIGs.
> > 
> > [Impact]
> > We tested the EOAN kernel on the LENOVO or Dell machines which have
> > dmic directly connnected to PCH, the dmic didn't work.
> > 
> > [Fix]
> > We need to enable SOF_HDA link and codec, then the sof driver
> > and Legacy HDA driver work together to make the dmic work.
> > 
> > [Test Case]
> > Install the latest 19.10 image, build a new kernel with this
> > patch and replace the existing kernel, After installing the blacklist
> > package (blacklist snd_hda_intel and snd_soc_skl) and ucm package,
> > the dmic and all output devices (speaker/hdmi) work.
> > 
> > [Regression Risk]
> > Low, these configs are already enabled in the oem-b-osp1 kernel
> > for a long time, and we tested it on many lenovo/dell machines witch
> > have or have no dmic, all worked well.
> 
> I got an email separately regarding these config problems, this is a
> needed change.
> 
> Acked-by: Seth Forshee <seth.forshee at canonical.com>

Oh, also these options should be updated in the annotations file and
enforced. My ack is contigent on this, whether it's done by sending a v2
or by whoever applies the patch.