ACK: APPLIED[Unstable]/cmt: [X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

[Seth Forshee]

On Wed, Oct 16, 2019 at 03:10:36PM -0300, Heitor Alves de Siqueira wrote:
> On Tue, Oct 15, 2019 at 3:45 PM Seth Forshee <seth.forshee at canonical.com> wrote:
> >
> > I'm surprised we haven't noticed this before. I'm not sure how this
> > benefits disco though, or even xenial and bionic as afaik we aren't
> > still generating desktop installer images using the GA kernel. Even for
> > eoan, is there any benefit unless we respin to include the change (which
> > seems unlikely at this point)?
> >
> > We do want to make sure this gets into the hwe-edge kernel though to
> > ensure it's included in the next 20.04 point release.
> >
> > Applied to unstable/master. Holding my ack for the stable series kernels
> > until I understand what benefit there is to having it there.
> >
> > Thanks,
> > Seth
> 
> Hi Seth!
> Thanks for applying it to unstable. Apologies for not tagging the patch for
> that, but it would indeed be good to have that in the 20.04 release! :)
> 
> As for the other stable series, wouldn't the netboot mini.iso benefit from
> having the driver included? I think that would get automatically rebuilt to
> include this change, so users working with the daily releases or the mini.iso
> would still benefit from this patch (even if we don't have any new point
> releases for the older Series). Would that be an appropriate use case?

I wasn't aware we did daily builds of the mini.iso for stable releases,
and I wouldn't have guessed that the sorts of systems with wireless
cards are generally netbooted. But if so the change is useful, and even
if not it should be harmless, so:

Acked-by: Seth Forshee <seth.forshee at canonical.com>