[PATCH 1/1][SRU][X] bcache: add cond_resched() in __bch_cache_cmp()

Connor Kuehl connor.kuehl at canonical.com
Tue Oct 15 17:03:08 UTC 2019


On 10/10/19 1:19 PM, Heitor Alves de Siqueira wrote:
> From: Shile Zhang <shile.zhang at linux.alibaba.com>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 940ba3e1bad1..057804caeed2 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -820,7 +820,7 @@ SHOW(__bch_cache)
>   
>   	if (attr == &sysfs_priority_stats) {
>   		int cmp(const void *l, const void *r)
> -		{	return *((uint16_t *) r) - *((uint16_t *) l); }
> +		{	cond_resched(); return *((uint16_t *) r) - *((uint16_t *) l); }

Just a nit-pick, but because it's already a backport and now we've got 
two separate statements here, I think they should each be on their own 
lines. Aside from that it looks good to me and my ack will be sent to 
the patch cover letter in just a moment.

>   
>   		struct bucket *b;
>   		size_t n = ca->sb.nbuckets, i;
> 




More information about the kernel-team mailing list