ACK/Cmnt: [SRU] [B/D/E/OEM-B/OEM-OSP1-B] [PATCH 0/3] Fix non-working Realtek USB ethernet after system resume

Connor Kuehl connor.kuehl at canonical.com
Thu Oct 10 15:30:08 UTC 2019


On 10/7/19 3:45 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1847063
> 
> [Impact]
> If mac passthrough is enbled, Realtek USB ethernet (r8152) doesn't work
> under the following steps:
> 1. Connect to a Dell dock
> 2. Suspend the system
> 3. Re-plug the dock
> 4. Resume the system
> 5. Ethernet stops working
> 
> [Fix]
> The USB port lose its power when the dock gets replugged, so we need to
> re-write the MAC address at reset_resume callback.
> 
> [Test]
> The fix is succesfully tested on Dell WD15 dock and TB16 dock.
> 
> [Regression Potential]
> Low. The fix limits to one single device and only take affect when MAC
> passthrough is enabled.
> 
> Kai-Heng Feng (1):
>    r8152: Set macpassthru in reset_resume callback
> 
> Mario Limonciello (2):
>    r8152: remove extra action copying ethernet address
>    r8152: Refresh MAC address during USBDEVFS_RESET
> 
>   drivers/net/usb/r8152.c | 54 +++++++++++++++++++++++++++--------------
>   1 file changed, 36 insertions(+), 18 deletions(-)
> 

Apologies if I missed it, but I suspect the backport line in "[B/OEM-B] 
[PATCH 2/3] r8152: Refresh MAC address during USBDEVFS_RESET" was just 
an offset/context adjustment, right?

Acked-by: Connor Kuehl <connor.kuehl at canonical.com>



More information about the kernel-team mailing list