ACK/Cmnt: [SRU][OEM-B-OSP1/E/unstable][PATCH v2 0/2] drm/i915: Fix the issue of "azx_get_response timeout" for hdmi audio on ICL platforms

[Stefan Bader]

On 09.10.19 10:08, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1847192
> 
> In the V2, I dropped the Disco, so these two patches will not be
> merged to Disco since Disco kernel doesn't support ICL graphic,
> these two patches are useless to Disco kernel.
> 
> 
> 
> Since Bionic kernel doesn't support ICL platforms (i915), so these two
> patches will not be sent to Bionic kernel.
> 
> [Impact]
> On the ICL platforms, the hdmi can't work well, the audio driver
> will print "azx_get_response timeout" randomly, then the whole
> audio doesn't work anymore.
> 
> [Fix]
> Intel provide these two fixes to us, and we tested these two
> patches, it really fixed the issue.
> 
> [Test Case]
> Boot and check the hdmi audio, then suspend and resume, check
> the hdmi audio, all work well.
> 
> [Regression Risk]
> Low, Only enable the audio PIN and enable the clock for ICL. we
> tested on both ICL and non-ICL, all worked well as before.
> 
> 
> Kai Vehmanen (2):
>   UBUNTU: SAUCE: drm/i915: Fix audio power up sequence for gen10+
>     display
>   UBUNTU: SAUCE: drm/i915: extend audio CDCLK>=2*BCLK constraint to more
>     platforms
> 
>  drivers/gpu/drm/i915/i915_reg.h    |  3 +++
>  drivers/gpu/drm/i915/intel_audio.c | 11 ++++++++---
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
Hrm, this sounds like for the initial submission for Disco nobody actually
bothered to even test compile. If that is the new level of quality there might
be a mandatory build log for every series requested in the future...

For now, but rather grumpy,

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20191009/dda1f6e9/attachment.sig>