ACK: [PATCH 1/2][SRU][B][OEM-B] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

Connor Kuehl connor.kuehl at canonical.com
Fri Oct 4 22:16:40 UTC 2019


On 10/3/19 12:50 AM, You-Sheng Yang wrote:
> From: Alexander Abrosimov <alexander.n.abrosimov at gmail.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1846453
> 
> SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> 2-in-1 devices like tablets, convertibles and detachables. Dell's
> Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> be added to the DMI whitelist, so rfkill and backlight can be controlled
> for them as for other laptops.
> 
> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov at gmail.com>
> Reviewed-by: Mario Limonciello <mario.limonciello at dell.com>
> Signed-off-by: Darren Hart (VMware) <dvhart at infradead.org>
> (cherry picked from commit fe486138788ba435ffa918c8d7aba05a77b6289a)
> Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>

Acked-by: Connor Kuehl <connor.kuehl at canonical.com>

> ---
>   drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++++++++++
>   1 file changed, 36 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index bb83e2c30601..f484b5a989cd 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -108,6 +108,42 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
>   			DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
>   		},
>   	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> +		},
> +	},
>   	{
>   		.ident = "Dell Computer Corporation",
>   		.matches = {
> 




More information about the kernel-team mailing list