[Acked/CMT] [PATCH][SRU][E] UBUNTU: SAUCE: s390: Mark atomic const ops always inline

Andy Whitcroft apw at canonical.com
Tue Oct 1 12:32:27 UTC 2019


On Mon, Sep 30, 2019 at 09:06:05PM -0500, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1846143
> 
> I get the following error building zfs for s390 with debug
> symbols enabled:
> 
> ./arch/s390/include/asm/atomic_ops.h:46:2: error: impossible constraint in ‘asm’
> 
> Similar problems have been fixed in the past by using
> __always_inline to force inlining, and trying the same here fixes
> the build.
> 
> Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
> ---
>  arch/s390/include/asm/atomic_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/include/asm/atomic_ops.h b/arch/s390/include/asm/atomic_ops.h
> index d3f09526ee19..61467b9eecc7 100644
> --- a/arch/s390/include/asm/atomic_ops.h
> +++ b/arch/s390/include/asm/atomic_ops.h
> @@ -41,7 +41,7 @@ __ATOMIC_OPS(__atomic64_xor, long, "laxg")
>  #undef __ATOMIC_OP
>  
>  #define __ATOMIC_CONST_OP(op_name, op_type, op_string, op_barrier)	\
> -static inline void op_name(op_type val, op_type *ptr)			\
> +static __always_inline void op_name(op_type val, op_type *ptr)		\
>  {									\
>  	asm volatile(							\
>  		op_string "	%[ptr],%[val]\n"			\
> -- 
> 2.20.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

"Trying the same here ..." wimper.  But if it makes it build I guess:

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw



More information about the kernel-team mailing list