NAK: [SRU][E][PATCH 1/6] perf/x86: Support constraint ranges

You-Sheng Yang vicamo.yang at canonical.com
Wed Nov 27 07:25:08 UTC 2019



On 2019-11-26 22:40, Anthony Wong wrote:
> On Thu, Nov 21, 2019 at 04:15:33PM +0800, You-Sheng Yang wrote:
>> From: Peter Zijlstra <peterz at infradead.org>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1848978
>>
>> Icelake extended the general counters to 8, even when SMT is enabled.
>> However only a (large) subset of the events can be used on all 8
>> counters.
>>
>> The events that can or cannot be used on all counters are organized
>> in ranges.
>>
>> A lot of scheduler constraints are required to handle all this.
>>
>> To avoid blowing up the tables add event code ranges to the constraint
>> tables, and a new inline function to match them.
>>
>> Originally-by: Andi Kleen <ak at linux.intel.com>
>> Signed-off-by: Peter Zijlstra (Intel) <peterz at infradead.org> # developer hat on
>> Signed-off-by: Kan Liang <kan.liang at linux.intel.com>
>> Signed-off-by: Peter Zijlstra (Intel) <peterz at infradead.org> # maintainer hat on
>> Cc: Alexander Shishkin <alexander.shishkin at linux.intel.com>
>> Cc: Arnaldo Carvalho de Melo <acme at redhat.com>
>> Cc: Jiri Olsa <jolsa at redhat.com>
>> Cc: Linus Torvalds <torvalds at linux-foundation.org>
>> Cc: Peter Zijlstra <peterz at infradead.org>
>> Cc: Stephane Eranian <eranian at google.com>
>> Cc: Thomas Gleixner <tglx at linutronix.de>
>> Cc: Vince Weaver <vincent.weaver at maine.edu>
>> Cc: acme at kernel.org
>> Cc: jolsa at kernel.org
>> Link: https://lkml.kernel.org/r/20190402194509.2832-8-kan.liang@linux.intel.com
>> Signed-off-by: Ingo Molnar <mingo at kernel.org>
>> (backported from commit 63b79f6ebc464afb730bc45762c820795e276da1)
>> Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>
>> ---
>>  arch/x86/events/perf_event.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/x86/events/perf_event.h b/arch/x86/events/perf_event.h
>> index 8751008fc170..6d144f6e9573 100644
>> --- a/arch/x86/events/perf_event.h
>> +++ b/arch/x86/events/perf_event.h
>> @@ -381,6 +381,9 @@ struct cpu_hw_events {
>>  #define INTEL_FLAGS_EVENT_CONSTRAINT_RANGE(c, e, n)			\
>>  	EVENT_CONSTRAINT_RANGE(c, e, n, ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS)
>>  
>> +#define INTEL_FLAGS_EVENT_CONSTRAINT_RANGE(c, e, n)			\
>> +	EVENT_CONSTRAINT_RANGE(c, e, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS)
>> +
>>  /* Check only flags, but allow all event/umask */
>>  #define INTEL_ALL_EVENT_CONSTRAINT(code, n)	\
>>  	EVENT_CONSTRAINT(code, n, X86_ALL_EVENT_FLAGS)
> 
> This patch looks weird, you are defining INTEL_FLAGS_EVENT_CONSTRAINT_RANGE
> again by reverting 6b89d4c1a.

Thank you. I'll drop this patch from patchset for Eoan, and add
6b89d4c1a to D/OEM-OSP1-B to address that bug.

> Thanks,
> Anthony
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20191127/3c31d38a/attachment-0001.sig>


More information about the kernel-team mailing list