[SRU][D][PATCH RESEND 1/1] UBUNTU: SAUCE: platform/x86: intel_pmc_core: Add Comet Lake (CML) platform support to intel_pmc_core driver

You-Sheng Yang vicamo.yang at canonical.com
Tue Nov 26 11:08:16 UTC 2019

From: Gayatri Kammela <gayatri.kammela at intel.com>

BugLink: https://bugs.launchpad.net/bugs/1847450

Add Comet Lake to the list of the platforms that intel_pmc_core driver
supports for pmc_core device.

Just like Ice Lake, Comet Lake can also reuse all the Cannon Lake PCH
IPs. No additional effort is needed to enable but to simply reuse them.

Cc: Mario Limonciello <mario.limonciello at dell.com>
Cc: Peter Zijlstra <peterz at infradead.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada at intel.com>
Cc: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Cc: Kan Liang <kan.liang at intel.com>
Cc: David E. Box <david.e.box at intel.com>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
Cc: Tony Luck <tony.luck at intel.com>
(backported from https://lkml.org/lkml/2019/11/18/713)
Signed-off-by: Gayatri Kammela <gayatri.kammela at intel.com>
 drivers/platform/x86/intel_pmc_core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index af303dcd581c..b03c484a3702 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -145,6 +145,7 @@ static const struct pmc_reg_map spt_reg_map = {
 /* Cannonlake: PGD PFET Enable Ack Status Register(s) bitmap */
 static const struct pmc_bit_map cnp_pfear_map[] = {
+	/* Reserved for Cannon Lake but valid for Comet Lake */
 	{"PMC",                 BIT(0)},
 	{"OPI-DMI",             BIT(1)},
 	{"SPI/eSPI",            BIT(2)},
@@ -743,6 +744,8 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
+	ICPU(INTEL_FAM6_COMETLAKE, &cnp_reg_map),
+	ICPU(INTEL_FAM6_COMETLAKE_L, &cnp_reg_map),

More information about the kernel-team mailing list