ACK/cmt: [SRU][X, B, D] backport DIMLIB (lib/dim/) to pre-5.2 kernels
Kamal Mostafa
kamal at canonical.com
Mon Nov 25 23:11:27 UTC 2019
In this instance, it shouldn't matter whether the config-enable appears
before or after the import (there aren't any consumers of the imported lib
until a subsequent pull req). I don't have any preference either way --
feel free to move it at apply time if you prefer.
-Kamal
On Mon, Nov 25, 2019 at 8:44 AM Khaled Elmously <
khalid.elmously at canonical.com> wrote:
> On 2019-11-15 08:55:31 , Kamal Mostafa wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1852637
> >
> > The mellanox and broadcom drivers contained a "dynamic interrupt
> > moderation" feature (as early as v5.0) which was broken out into a
> > common kernel library 'DIMLIB' in lib/dim/ circa mainline v5.2.
> >
> > Backported drivers may now need DIMLIB to be available in pre-5.2
> > kernels (specifically, the latest upstream version of
> > net/ethernet/amazon/ena does).
> >
> > Pull req's to follow ...
> >
> > For Disco:
> > Apply all the mainline commits from v5.2 which extract DIMLIB from
> > mellanox/broadcom and wire those drivers to use DIMLIB (plus a few
> > later DIMLIB fixes). I.e. make Disco work the same as > 5.2 kernels;
> > no significant functional change to those drivers.
> >
> > For Bionic and Xenial:
> > Import the lib/dim/ directory from mainline (plus a couple porting
> > prerequisites), but do *not* make mellanox/broadcom use it. I.e. no
> > functional change at all.
> >
> > -Kamal
> >
>
> Does it make sense to have the "[Config] enable DIMLIB" patch after the
> "import DIMLIB (lib/dim/)" change?
> Either way,
>
> Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20191125/6073f076/attachment.html>
More information about the kernel-team
mailing list