ACK: [SRU][B/D/E/F][PATCH 0/1] i40e: Setting VF MAC address causes General Protection Fault

Kamal Mostafa kamal at canonical.com
Mon Nov 25 16:08:07 UTC 2019


LGTM.

Acked-by: Kamal Mostafa <kamal at canonical.com>

 -Kamal

On Wed, Nov 13, 2019 at 10:39:16AM -0300, Heitor Alves de Siqueira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1852432
> 
> [Impact]
>  * Creating SR-IOV enabled VMs in Openstack can sometimes trigger the GPF and
>    leave system unusable
> 
> [Test Case]
>  * Continuously spin up VFs and set MAC address with e.g. ifconfig
> 
> [Fix]
>  * The fix updates the VSI pointer passed down to i40e_set_vf_mac function() if
>    the adapter is still in reset, preventing the GPF.
> 
> [Regression Potential]
>  * Regression potential should be low, as we're now updating the VSI using the
>    ID stored in the VF pointer
>  * Regressions could arise from issues in VF creation or reset, as that would
>    corrupt the new VSI pointer
>  * Patch was validated and tested in a production environment
> 
> Slawomir Laba (1):
>   i40e: Fix crash caused by stress setting of VF MAC addresses
> 
>  drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> -- 
> 2.23.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list