ACK: [PATCH 0/4][SRU][B][D][E][OEM-B][OEM-OSP1-B] Can't adjust brightness on
Connor Kuehl
connor.kuehl at canonical.com
Tue Nov 12 18:16:52 UTC 2019
On 11/6/19 10:36 PM, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1813877
>
> [Impact]
> The dell-uart-backlight driver has been loaded, but the backlight is
> controller by graphics driver instead of scalar IC. The old way to
> determinate weather the driver should be loaded is not working anymore,
> since the behavior of scalar command, show firmware version, is not the
> same as old platforms.
>
> [Fix]
> Using more a reliable command, get_scalar_status, to check if scalar is in
> charge of the AIO backlight.
> For the old platforms which don't have the new command, I add a list to
> list them all and use the old way to determinate the scalar IC.
>
> [Test]
> Verified on old and new Dell AIO platforms.
>
> [Regression Potential]
> Low. The quirk lists all old platforms which use the old way to check if
> scalar IC is in use. So, it won't change the behavior on old platforms,
> and apply the new method on new platforms.
>
> AceLan Kao (4):
> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add missing status
> command
> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: load driver by
> scalar status
> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add force parameter
> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add quirk for old
> platforms
>
> drivers/platform/x86/dell-uart-backlight.c | 73 +++++++++++++++++++---
> 1 file changed, 64 insertions(+), 9 deletions(-)
>
Acked-by: Connor Kuehl <connor.kuehl at canonical.com>
More information about the kernel-team
mailing list