NAK: [PATCH 0/4][SRU][D][E][F][OEM-B][OEM-B-OSP1] The system cannot resume from S3 if user unplugs the TB16 during suspend state

Seth Forshee seth.forshee at canonical.com
Mon Nov 11 20:01:49 UTC 2019


On Fri, Nov 01, 2019 at 11:46:48AM +0800, AceLan Kao wrote:
> Hi Seth,
> 
> I think you are mentioning the 4th commit.
> https://lists.ubuntu.com/archives/kernel-team/2019-October/104951.html
> It change the return type of pciehp_check_link_active() from bool to
> int to indicate different state.
> 
> AFAIK, there is no other thread discuss this change, and Mika doesn't
> reply to us if he will keep pushing the changes to upstream.
> When I asked him if those commits introduce any regression he can
> think of, he just reply "I don't think there is any risk of
> regressions."

I'm still not entirely comfortable with these as sauce patches, as they
look like they could complicate backporting other fixes. But the impact
on affected systems is pretty severe, so we probably should take them.

However, it looks like these are the v2 patches and that there is a v3
upstream:

https://lore.kernel.org/lkml/20191029170022.57528-1-mika.westerberg@linux.intel.com/

So I think these should be refreshed to use the newer patches.

Thanks,
Seth



More information about the kernel-team mailing list