[x/azure][PATCH 2/3] nvme-pci: remove cq check after submission

Marcelo Henrique Cerri marcelo.cerri at canonical.com
Wed May 29 18:18:43 UTC 2019

From: Jens Axboe <axboe at kernel.dk>

BugLink: http://bugs.launchpad.net/bugs/1830242

We always check the completion queue after submitting, but in my testing
this isn't a win even on DRAM/xpoint devices. In some cases it's
actually worse. Kill it.

Signed-off-by: Jens Axboe <axboe at kernel.dk>
Signed-off-by: Keith Busch <keith.busch at intel.com>
Signed-off-by: Christoph Hellwig <hch at lst.de>
(cherry picked from commit f9dde187fa921c12a8680089a77595b866e65455)
Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri at canonical.com>
 drivers/nvme/host/pci.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 78972f85df3c..c93d6ab3f55f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -69,7 +69,6 @@ MODULE_PARM_DESC(io_queue_depth, "set io queue depth, should >= 2");
 struct nvme_dev;
 struct nvme_queue;
-static void nvme_process_cq(struct nvme_queue *nvmeq);
 static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown);
@@ -902,7 +901,6 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
 		goto out_cleanup_iod;
 	__nvme_submit_cmd(nvmeq, &cmnd);
-	nvme_process_cq(nvmeq);
 	return BLK_STS_OK;

More information about the kernel-team mailing list