ACK: [SRU][Xenial][PATCH 0/1] Fix for glibc vdso regression (LP: #1830890)

[Colin Ian King]

On 29/05/2019 17:59, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1830890
> 
> [Impact]
> Some glibc testcases are regressing on i386 after the following commit
> was applied to xenial/linux as part of upstream stable update 4.4.179:
> 
> commit 379d98ddf41344273d9718556f761420f4dc80b3
> Author: Alistair Strachan <astrachan at google.com>
> Date: Fri Aug 3 10:39:31 2018 -0700
> 
>     x86: vdso: Use $LD instead of $CC to link
> 
> which accidentally broke unwinding from userspace, because ld would
> strip the .eh_frame sections when linking.
> 
> Test logs:
>     i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/g/glibc/20190528_085308_d03ca@/log.gz
> 
> [Fix]
> The following commit fixes the issue:
> 
> commit cd01544a268ad8ee5b1dfe42c4393f1095f86879
> Author: Alistair Strachan <astrachan at google.com>
> Date: Fri Dec 14 14:36:37 2018 -0800
> 
>     x86/vdso: Pass --eh-frame-hdr to the linker
> 
> It was applied to 4.4.180, but we need to apply it before otherwise
> xenial/linux will be released with a regression.
> 
> [Test]
> ADT tests for glibc.
> 
> [Regression Potential]
> Low. One line patch to Makefile which fixes a known regression.
> 
> Alistair Strachan (1):
>   x86/vdso: Pass --eh-frame-hdr to the linker
> 
>  arch/x86/entry/vdso/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Makes sense. Positive test results.

Acked-by: Colin Ian King <colin.king at canonical.com>