NACK Re: [SRU][OEM-D][PULL] Enable Icelake S0ix

[Timo Aaltonen]

On 20.5.2019 4.57, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1819413
> 
> [Impact]
> Requires patches to make new INTEL CPU IceLake support s0ix
> 
> [Fix]
> The patch list is provided by Intel
>    238f9c11351f platform/x86: intel_pmc_core: Quirk to ignore XTAL
> shutdown
>    8aba056a4ea6 platform/x86: intel_pmc_core: Add Package cstates residency info
>    6769fdbe27d7 platform/x86: intel_pmc_core: Add ICL platform support
>    cfb55af9add9 platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro
>    4a5861f71429 platform/x86: intel_pmc_core: Avoid a u32 overflow
>    2a13096ac7da platform/x86: intel_pmc_core: Include Reserved IP for LTR
>    cd89e92b7399 platform/x86: intel_pmc_core: Fix file permissions for ltr_show
>    d6827015e671 platform/x86: intel_pmc_core: Fix PCH IP name
>    0e68eeea9894 platform/x86: intel_pmc_core: Fix PCH IP sts reading
>    e50af8332785 platform/x86: intel_pmc_core: Handle CFL regmap properly
> 
> Below commit fix 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to
> ignore XTAL shutdown")
>    9ae11e237d95 platform/x86: intel_pmc_core: Mark local function static
> 
> [Test]
> Verified on Intel ICL-Y SDP with fwts s2idle test 30 times, the system is
> still working.
> 
> [Regression Risk]
> Low. Those patches are all small changes, and most of them are adding IDs,
> should be safe to include them.
> 
> 
> The following changes since commit 3bc1d19e09dd75355f9acdaefe8431a4561563d8:
> 
>   UBUNTU: Ubuntu-oem-osp1-5.0.0-1006.7 (2019-05-06 12:49:50 +0300)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~acelankao/+git/ubuntu-disco s0ix
> 
> for you to fetch changes up to d3ca5c0122c2f9eaaca3c943157f690737f68d5c:
> 
>   platform/x86: intel_pmc_core: Mark local function static (2019-05-17 10:35:19 +0800)
> 
> ----------------------------------------------------------------
> Guenter Roeck (1):
>       platform/x86: intel_pmc_core: Mark local function static
> 
> Rajat Jain (1):
>       platform/x86: intel_pmc_core: Avoid a u32 overflow
> 
> Rajneesh Bhardwaj (9):
>       platform/x86: intel_pmc_core: Handle CFL regmap properly
>       platform/x86: intel_pmc_core: Fix PCH IP sts reading
>       platform/x86: intel_pmc_core: Fix PCH IP name
>       platform/x86: intel_pmc_core: Fix file permissions for ltr_show
>       platform/x86: intel_pmc_core: Include Reserved IP for LTR
>       platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro
>       platform/x86: intel_pmc_core: Add ICL platform support
>       platform/x86: intel_pmc_core: Add Package cstates residency info
>       platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown
> 
>  drivers/platform/x86/intel_pmc_core.c | 159 ++++++++++++++++++++++++++++------
>  drivers/platform/x86/intel_pmc_core.h |  14 ++-
>  2 files changed, 145 insertions(+), 28 deletions(-)

apparently there's more to come from upstream, so NACK until we have them


-- 
t