NAK: [PATCH 0/3][linux-firmware][SRU][B][D] Intel CyclonePeak wifi firmware

[AceLan Kao]

Seth,

The three commits doesn't update any firmwares, they are all new.
The -46 firmwares will be used by kernel newer than v5.1, so it won't
affect current v4.15 and v5.0 kernel.
I've provide the similar description on regression risk part
<quote>
[Regression Risk]
Low. Those firmware are for new cards and new ABI, it won't affect current
Intel wifi cards, and won't take effect on Bionic(4.15) kernel.
Only iwlwifi DKMS driver or oem-osp1 kernel loads those firmware.
</quote>

Do you still think I should remove the 9000 series firmware?

Best regards,
AceLan Kao.

Seth Forshee <seth.forshee at canonical.com> 於 2019年5月14日 週二 下午8:48寫道：
>
> On Thu, May 09, 2019 at 10:44:16AM +0800, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1828133
> >
> > [Impact]
> > New Intel CyclonePeak Wifi cards require new firmware to enable.
> >
> > [Fix]
> > To avoid conflicts, also update 9000 series firmware to ABI 46 which has
> > been added since v5.1-rc1 from iwlwifi tree[1] for-upstream branch
> >    95a93535 iwlwifi: update -46 firmwares for 22260 and 9000 series
> >    68040ceb iwlwifi: add firmware for 22260 and update 9000 series -46 firmwares
> >    fdfb1531 iwlwifi: add -46.ucode firmwares for 9000 series
>
> We've received pushback from the SRU team recently when updating
> firmware for hardware other than the target of the bug, even when
> upstream bundles the updates together. It does make cherry picking
> patches easier, but unless there's good reason to add the 9000 series
> firmware updates we should omit them. So you'll need to either provide
> better justification for the 9000 series updates or redo the series to
> omit them.
>
> Thanks,
> Seth
>