NACK/Cmnt: [Bionic][Cosmic][Disco] UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14)

[Stefan Bader]

On 10.05.19 16:14, Jeremy Soller wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> A mistake was made in the identification of the four variants of the System76
> Gazelle (gaze14). This patch corrects the PCI ID of the 17-inch, GTX 1660 Ti
> variant from 0x8560 to 0x8551. This patch also adds the correct fixups for the
> 15-inch and 17-inch GTX 1650 variants with PCI IDs 0x8560 and 0x8561.
> 
> Tests were done on all four variants ensuring full audio capability.
> 
> Signed-off-by: Jeremy Soller <jeremy at system76.com>
> 
> ---

This is not the way SRU works.

a) you already submitted a patch which differed from the upstream patch
   and which was using the same bug number. That had been applied and
   from what I saw there was no follow-up to notify us about the problem.
b) you submit a follow-up SAUCE patch with the exact same title as the
   previous patch again without reference to upstream. There should be no
   SRU submission which is not at least in linux-next.

By now it looks like what should have been submitted is:

commit 80a5052db75131423b67f38b21958555d7d970e4
Author: Jeremy Soller <jeremy at system76.com>
Date:   Tue May 7 17:11:08 2019 -0400

    ALSA: hdea/realtek - Headset fixup for System76 Gazelle (gaze14)

and

commit 891afcf2462d2cc4ef7caf94215358ca61fa32cb linux-next
Author: Jeremy Soller <jeremy at system76.com>
Date:   Fri May 10 10:15:07 2019 -0400

    ALSA: hda/realtek - Corrected fixup for System76 Gazelle (gaze14)

where both have a proper cherry picked from reference (if they are applicable
that way to all series) and signed-off and include the bug reference (if they
are both coming the same time, that is ok).

Waiting on that,
Stefan

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b3712d87e98b..3e790b49c1c0 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6901,7 +6901,9 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> -	SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +	SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> +	SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
>  	SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
>  	SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190514/25e996f5/attachment.sig>