[PATCH v2 0/6][linux-signed*][SRU Bionic][SRU Cosmic][SRU Bionic] Correct source package in Built-Using control field

[Khaled Elmously]

On 2019-05-09 09:00:08 , dann frazier wrote:
> On Wed, May 8, 2019 at 11:47 PM Khaled Elmously
> <khalid.elmously at canonical.com> wrote:
> >
> > I'm a little confused by this patchset. I'm not sure where each patch is supposed to go, or why only one of the patches is a v2, or why Bionic is tagged twice, or which -hwe is the intended target, or...
> 
> Khaled,
>   Sorry - the missing "v2" on patches 2-6 was a mistake. They should all be v2.
> 
> AIUI, the list's preference is to have things like this all in one
> thread (vs. separate threads for package), but that kinda obfuscates
> the patch numbering. The pattern I used was that you should be able to
> apply these patches in order, but the trees/branches to which you'd
> apply them will change as you go, as listed in the subject line tags.
> 
> To be explicit:
>   Patch 1/2: linux-signed/cosmic
>                    linux-signed/bionic
>   Patch 3/4: linux-signed-hwe-edge/bionic
>                    linux-signed-hwe/bionic
>                    linux-signed-hwe-edge/xenial
>                    linux-signed-hwe/xenial
>   Patch 5/6: linux-signed/xenial
> 
> Always happy to change my process to make it easier - just let me know
> if you have suggestions :)
> 
>   -dann
> 

Thans Dann. It makes sense the way you did it - AFTER you explained it :)

I don't have a better idea on how to do a patchset like this in the future (other than to hope to use a review tool that automates all of this)


> >
> >
> > On 2019-04-27 15:17:19 , dann frazier wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1824016
> > >
> > > Backports of patches already applied to Disco.
> > >
> > > The Built-Using field hardcodes "linux" as the source package, even for the
> > > hwe & hwe-edge packages. Correct that. Technically only the
> > > linux-signed-hwe{-edge} packages need this fix, but I'm including patches
> > > for linux-signed as well to prevent future occurences due to cargo-culting.
> > >
> > > Verified by confirming that the same control file is generated before
> > > and after this change for linux-signed, and Built-Using is now correct
> > > for the hwe packages.
> > >
> > > v2:
> > >   * Clarify the vague PACKAGE, VERSION template vars by prefixing
> > >     them with "UNSIGNED_SRC_".
> > >
> > > --
> > > kernel-team mailing list
> > > kernel-team at lists.ubuntu.com
> > > https://lists.ubuntu.com/mailman/listinfo/kernel-team