[PATCH 0/6] [Disco SRU] Use gpiolib for chipselect in DW SPI driver

Ike Panhc ike.pan at canonical.com
Thu May 9 03:10:42 UTC 2019


On 5/8/19 7:35 PM, Kleber Souza wrote:
> On 5/6/19 11:19 AM, Ike Panhc wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1826142
>>
>> Current spi-dw-mmio driver needs hardware description from devicetree
>> or acpitables for chipselect but only support devicetree. Here are
>> patches to enable ACPI support for DW SPI driver so that the TPM
>> module can be supported on ACPI machines.
>>
>> The first patch for spi core provides new method to set gpio pin with
>> gpiolib if use_gpio_descriptors=true and legacy method is still
>> available if use_gpio_descriptors=false.
>>
>> The 2nd patch is to switch DW SPI driver to use gpiolib for
>> chipselect so the duplicate devicetree code can be removed.
>>
>> The rest of patches are minor regression fixes collected from 
>> mainline about unused variable and default polarity of gpio pin.
>>
>>
>> Anders Roxell (1):
>>   spi: dw: fix warning unused variable 'ret'
>>
>> Linus Walleij (5):
>>   spi: Optionally use GPIO descriptors for CS GPIOs
>>   spi: dw: Convert to use CS GPIO descriptors
>>   spi: Support high CS when using descriptors
>>   spi: dw: Fix default polarity of native chipselect
>>   gpio: of: Fix logic inversion
>>
>>  drivers/gpio/gpiolib-of.c |   2 +-
>>  drivers/spi/spi-dw-mmio.c |  22 --------
>>  drivers/spi/spi-dw.c      |  15 ++----
>>  drivers/spi/spi.c         | 109 ++++++++++++++++++++++++++++++++++----
>>  include/linux/spi/spi.h   |  23 ++++++--
>>  5 files changed, 122 insertions(+), 49 deletions(-)
>>
> 
> Hi Ike,
> 
> There is another commit upstream that states to fix f3186dd876697e69
> ("spi: Optionally use GPIO descriptors for CS GPIOs"):
> 
> commit 1723fdec5fcbc4de3d26bbb23a9e1704ee258955
> Author: Geert Uytterhoeven <geert+renesas at glider.be>
> Date:   Wed Apr 3 16:46:56 2019 +0200
>     spi: Add missing error handling for CS GPIOs
> 
> Is this commit needed as well?
> 
> 
> Thanks,
> Kleber
> 

Yes. this is needed too. I will re-send.

Thanks.



More information about the kernel-team mailing list