NAK: [SRU][Bionic][Cosmic][PATCH 1/1] geneve: Can't create geneve tunnels when ipv6 disabled dynamically

Nivedita Singhvi nivedita.singhvi at canonical.com
Tue May 7 16:56:45 UTC 2019


On 5/7/19 4:11 PM, Kleber Souza wrote:
> On 5/6/19 5:54 PM, Nivedita Singhvi wrote:
>> From: Jiri Benc <jbenc at redhat.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1794232
>>
>> When IPv6 is compiled but disabled at runtime, geneve_sock_add returns
>> -EAFNOSUPPORT. For metadata based tunnels, this causes failure of the whole
>> operation of bringing up the tunnel.
>>
>> Ignore failure of IPv6 socket creation for metadata based tunnels caused by
>> IPv6 not being available.
>>
>> This is the same fix as what commit d074bf960044 ("vxlan: correctly handle
>> ipv6.disable module parameter") is doing for vxlan.
>>
>> Note there's also commit c0a47e44c098 ("geneve: should not call rt6_lookup()
>> when ipv6 was disabled") which fixes a similar issue but for regular
>> tunnels, while this patch is needed for metadata based tunnels.
>>
>> Signed-off-by: Jiri Benc <jbenc at redhat.com>
>> Signed-off-by: David S. Miller <davem at davemloft.net>
>> (cherry picked from commit cf1c9ccba7308e48a68fa77f476287d9d614e4c7)
>> Signed-off-by: Nivedita Singhvi <nivedita.singhvi at canonical.com>
> 
> Hi Nivedita,
> 
> The patch itself looks good. Clean cherry-picked, tested and affects a single
> driver. However, the subject of the email doesn't match the title of the
> commit message. From the mainline git repo, the commit cf1c9ccba730 is
> named "geneve: correctly handle ipv6.disable module parameter" instead of
> "geneve: Can't create geneve tunnels when ipv6 disabled dynamically".
> 
> Could you please re-send the patch with the fixed title?

Hi Kleber,

Sure. Sending separately.

Nivedita




More information about the kernel-team mailing list