ACK/cmnt: [SRU] [V2] [B/C] [PATCH 0/8] Sync AMD MP2 I2C driver with upstream version
kleber.souza at canonical.com
Tue May 7 16:00:27 UTC 2019
On 4/25/19 6:43 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1787775
> v2: Build the driver as module for i386.
> AMD MP2 I2C driver doesn't support more than one bus.
> This makes touchpad on Lenovo Yoga 530 doensn't work as expected.
> Sync the MP2 driver with upstream version.
> The new upstream driver doesn't break on Latitude 5495.
> Users haven't given any feedback yet, but since Disco is freezing I
> am sending this out.
> [Regression Potential]
> Low. It's from upstream, and only a subset of Raven Ridge has this
The changes look good, and not removing the support for i386.
We should also update the annotations file to reflect the new config
values, but this is a small change and can be done while applying.
Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> Elie Morisse (1):
> i2c: Add drivers for the AMD PCIe MP2 I2C controller
> Kai-Heng Feng (4):
> Revert "UBUNTU: SAUCE: i2c:amd Depends on ACPI"
> Revert "UBUNTU: SAUCE: i2c:amd move out pointer in union
> Revert "UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for
> upcoming platform"
> UBUNTU: [Config] Update config for AMD MP2 I2C driver
> Wolfram Sang (3):
> i2c: add helpers to ease DMA handling
> i2c: add a message flag for DMA safe buffers
> i2c: add extra check to safe DMA buffer helper
> Documentation/i2c/busses/i2c-amd-mp2 | 23 +
> MAINTAINERS | 8 +
> .../config/amd64/config.common.amd64 | 2 +-
> debian.master/config/i386/config.common.i386 | 2 +-
> drivers/i2c/busses/Kconfig | 12 +-
> drivers/i2c/busses/Makefile | 3 +-
> drivers/i2c/busses/i2c-amd-mp2-pci.c | 483 ++++++++++++++
> drivers/i2c/busses/i2c-amd-mp2-plat.c | 367 ++++++++++
> drivers/i2c/busses/i2c-amd-mp2.h | 219 ++++++
> drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ------------------
> drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 -------
> drivers/i2c/busses/i2c-amd-platdrv.c | 335 ----------
> drivers/i2c/i2c-core-base.c | 51 ++
> include/linux/i2c.h | 3 +
> include/uapi/linux/i2c.h | 3 +
> 15 files changed, 1166 insertions(+), 1223 deletions(-)
> create mode 100644 Documentation/i2c/busses/i2c-amd-mp2
> create mode 100644 drivers/i2c/busses/i2c-amd-mp2-pci.c
> create mode 100644 drivers/i2c/busses/i2c-amd-mp2-plat.c
> create mode 100644 drivers/i2c/busses/i2c-amd-mp2.h
> delete mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c
> delete mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h
> delete mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c
More information about the kernel-team