ACK: [X][B][C][SRU][PATCHv2 0/1] selftests/ftrace: Fix kprobe string testcase to not probe notrace function

Khaled Elmously khalid.elmously at canonical.com
Tue May 7 04:15:46 UTC 2019


On 2019-04-25 13:59:37 , Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1825780
> 
> == Justification ==
> When running the ftrace in ubunut_kernel_selftests, the "Kprobe event
> string type argument" test will fail on Bionic / Cosmic i386:
>   [22] Kprobe event string type argument	[FAIL]
> 
> This is because the test was trying to probe a notrace function.
> # grep create_trace_kprobe /sys/kernel/debug/tracing/available_filter_functions
> #
> 
> == Fix ==
> 6fc7c411 (selftests/ftrace: Fix kprobe string testcase to not probe notrace function)
> This will change the event to trace in the test, from
> create_trace_kprobe to tracefs_create_dir
> 
> Patch can be cherry-picked for Cosmic.
> 
> For Bionic and Xenial, it can be cherry-picked after the commit 9855c462
> for bug 1812809.
> 
> Although we don't run this ftrace test in Xenial, it will still be a
> plus to fix this.
> 
> It's already been applied in D.
> 
> This patch belongs to a patchset [1], in which further limits
> kprobe-events probing on notrace function. Not sure if we need others
> but to address this issue for the testing tool this one will be suffice.
> 
> [1] https://lkml.org/lkml/2018/7/30/257
> 
> == Test ==
> Patch tested with Bionic / Cosmic i386. Test passed as expected:
>   [22] Kprobe event string type argument	[PASS]
> 
> == Regression potential ==
> None.
> This patch is just for the kernel testing tool.
> 
> 
> V2: Add missing BugLink in the patch.
> 
> Masami Hiramatsu (1):
>   selftests/ftrace: Fix kprobe string testcase to not probe notrace
>     function
> 
>  .../ftrace/test.d/kprobe/kprobe_args_string.tc     | 30 +++++++++-------------
>  .../selftests/ftrace/test.d/kprobe/probepoint.tc   |  2 +-
>  2 files changed, 13 insertions(+), 19 deletions(-)
> 
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>




More information about the kernel-team mailing list