ACK: [B][SRU][PATCH 0/2] Fix for tm-unavailable test in powerpc from ubuntu_kernel_selftests
connor.kuehl at canonical.com
Mon May 6 17:27:08 UTC 2019
On 4/23/19 3:55 AM, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1813129
> == Justification ==
> The tm-unavailable test in powerpc from ubuntu_kernel_selftests will
> fail on Bionic PowerPC:
> $ sudo ./tm-unavailable
> Checking if FP/VEC registers are sane after a FP unavailable exception...
> Illegal instruction
> This is because the Hardware Transactional Memory (HTM) is not supported
> on the revision of the processor in our PowerPC boxes.
> == Fix ==
> b395e55b (selftests/powerpc: Skip tm-unavailable if TM is not enabled)
> With a prerequisite to make it a clean cherry-pick:
> 5783ee6e (selftests/powerpc: Check for pthread errors in tm-unavailable)
> An extra check for this test:
> Will be added to ensure we have HTM support before start testing.
> For Xenial, we don't have this test in our tree thus it can be ignored.
> This patchset has already landed in Cosmic and newer, and can be
> cherry-picked for Bionic.
> For the prerequisite patch, it touches only the code in testing tool and
> improves the test case quality by adding check for pthread errors. So I
> think it's safe to bring this in.
> == Test ==
> Patch verified on a Bionic P9 system, the test will be marked as passed
> (skipped) with these two patches applied.
> == Regression potential ==
> This patchset is just for the kernel testing tool.
> Cyril Bur (1):
> selftests/powerpc: Check for pthread errors in tm-unavailable
> Gustavo Romero (1):
> selftests/powerpc: Skip tm-unavailable if TM is not enabled
> .../testing/selftests/powerpc/tm/tm-unavailable.c | 57 +++++++++++++++++-----
> 1 file changed, 45 insertions(+), 12 deletions(-)
Acked-by: Connor Kuehl <connor.kuehl at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5149 bytes
Desc: not available
More information about the kernel-team