[PATCH 0/6] [Disco SRU] Use gpiolib for chipselect in DW SPI driver

Stefan Bader stefan.bader at canonical.com
Mon May 6 09:39:53 UTC 2019


On 06.05.19 11:19, Ike Panhc wrote:
> BugLink: https://bugs.launchpad.net/bugs/1826142
> 
> Current spi-dw-mmio driver needs hardware description from devicetree
> or acpitables for chipselect but only support devicetree. Here are
> patches to enable ACPI support for DW SPI driver so that the TPM
> module can be supported on ACPI machines.
> 
> The first patch for spi core provides new method to set gpio pin with
> gpiolib if use_gpio_descriptors=true and legacy method is still
> available if use_gpio_descriptors=false.
> 
> The 2nd patch is to switch DW SPI driver to use gpiolib for
> chipselect so the duplicate devicetree code can be removed.
> 
> The rest of patches are minor regression fixes collected from 
> mainline about unused variable and default polarity of gpio pin.
> 
> 
> Anders Roxell (1):
>   spi: dw: fix warning unused variable 'ret'
> 
> Linus Walleij (5):
>   spi: Optionally use GPIO descriptors for CS GPIOs
>   spi: dw: Convert to use CS GPIO descriptors
>   spi: Support high CS when using descriptors
>   spi: dw: Fix default polarity of native chipselect
>   gpio: of: Fix logic inversion
> 
>  drivers/gpio/gpiolib-of.c |   2 +-
>  drivers/spi/spi-dw-mmio.c |  22 --------
>  drivers/spi/spi-dw.c      |  15 ++----
>  drivers/spi/spi.c         | 109 ++++++++++++++++++++++++++++++++++----
>  include/linux/spi/spi.h   |  23 ++++++--
>  5 files changed, 122 insertions(+), 49 deletions(-)
> 
This must be rather recent code to be needed in Disco. For the SRU I would like
to see a better argumentation about why this is needed (which functionality is
currently broken) and which platforms are affected (mentioning device-tree
points to Arm but this should be less guessing). Also, right now the reason for
not mentioning Eoan is likely that it is a copy forward kernel there. But
mentioning that helps to recognize someone has spent thoughts on it. Would also
be good to mention which upstream kernel version includes all requested patches.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190506/7f4548d4/attachment.sig>


More information about the kernel-team mailing list