ACK/cmnt: [T/X/B/C/D][SRU][PATCHv2 0/5] Enable the HiDPI compiled-in font support

[Kleber Souza]

On 3/19/19 9:34 AM, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1819881
>
> == Justification ==
> The console font size on a high resolution screen is only suitable for
> eagles, although we can choose a bigger font by running:
>   sudo dpkg-reconfigure console-setup
>
> But that is not enough, the font size before video driver kicks in is
> still small. If we need to debug some early stage issues that will be a
> problem.
>
>
> == Fix ==
> ac8b6f14 (Fonts: New Terminus large console font)
> Config for this TER16x32 and the compiled-in fonts support needs to be
> enabled to keep engineers away from ophthalmologists.
>
> * Disco
>   It's already there. Just need to enable the configs.
> * Cosmic / Bionic
>   Patch can be cherry-picked.
> * Xenial
>   It needs an extra patch to make it a clean cherry-pick:
>   * 7bcae826 (lib/fonts/Kconfig: keep non-Sparc fonts listed together
> * Trusty
>   It needs two extra patches to make it a clean cherry-pick:
>   * fonts: Add 6x10 font (33ac9dba)
>   * lib/fonts/Kconfig: keep non-Sparc fonts listed together (7bcae826).
>   And a config entry for the 6x10 font.
>
> Commit "fonts: Add 6x10 font" is just adding a new font.
> Commit "lib/fonts/Kconfig: keep non-Sparc fonts listed together" is
> just a patch for context rearrangement.
>
> I think these two are safe to be pulled-in.
>
>
> == Test ==
> Test kernels: http://people.canonical.com/~phlin/kernel/lp-1819881-font/
>
> Add "fbcon=font:TER16x32" to the GRUB_CMDLINE_LINUX in
> /etc/default/grub, and follow these steps.
>
> * Disco
>   sudo update-grub; sudo reboot
> * Cosmic / Bionic
>   Add "GRUB_GFXPAYLOAD_LINUX=3840x2160" to /etc/default/grub
>   sudo update-grub; sudo reboot
> * Xenial
>   sudo update-grub; sudo reboot
> * Trusty
>   sudo update-grub; sudo reboot (I need the proprietary nvidia driver
>   to boot for my SUT - Dell Precision M3800)
>
> The font before the video driver kicks in will get bigger.
>
> == Regression potential ==
> Minimal, changes are limited to adding console fonts, turn on fonts
> related kernel configs.
>
>
> Amanoel Dawod (1):
>   Fonts: New Terminus large console font
>
> Maarten ter Huurne (1):
>   fonts: Add 6x10 font
>
> Po-Hsu Lin (2):
>   UBUNTU: [Config]: Add 6x10 font config
>   UBUNTU: [Config]: enable highdpi Terminus 16x32 font support
>
> Randy Dunlap (1):
>   lib/fonts/Kconfig: keep non-Sparc fonts listed together
>
>  debian.master/config/amd64/config.common.amd64     |    2 +-
>  debian.master/config/annotations                   |    3 +-
>  debian.master/config/arm64/config.common.arm64     |    2 +-
>  debian.master/config/config.common.ubuntu          |    3 +
>  debian.master/config/i386/config.common.i386       |    2 +-
>  debian.master/config/powerpc/config.common.powerpc |    2 +-
>  debian.master/config/ppc64el/config.common.ppc64el |    2 +-
>  include/linux/font.h                               |    6 +-
>  lib/fonts/Kconfig                                  |   31 +-
>  lib/fonts/Makefile                                 |    2 +
>  lib/fonts/font_6x10.c                              | 3086 ++++++++++++++++++++
>  lib/fonts/font_ter16x32.c                          | 2072 +++++++++++++
>  lib/fonts/fonts.c                                  |    8 +
>  13 files changed, 5208 insertions(+), 13 deletions(-)
>  create mode 100644 lib/fonts/font_6x10.c
>  create mode 100644 lib/fonts/font_ter16x32.c
>
Agree with Stefan in leaving T out.

We might need to run 'updateconfigs' after applying to have the config
change only in the common file as Seth did for D.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>