[B/C][PATCH 2/2] r8152: Fix an error on RTL8153-BD MAC Address Passthrough support

Wen-chien Jesse Sung jesse.sung at canonical.com
Fri Mar 22 06:13:58 UTC 2019


From: David Chen <david.chen7 at dell.com>

BugLink: https://launchpad.net/bugs/1821276

RTL8153-BD is used in Dell DA300 type-C dongle.
Added RTL8153-BD support to activate MAC address pass through on DA300.
Apply correction on previously submitted patch in net.git tree.

Signed-off-by: David Chen <david.chen7 at dell.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit c286909fe5458f69e533c845b757fd2c35064d26)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>
---
 drivers/net/usb/r8152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index cc78e82bc94d..8db9392d76b9 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1179,7 +1179,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa)
 	} else {
 		/* test for RTL8153-BND and RTL8153-BD */
 		ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
-		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK)) {
+		if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK) == 0) {
 			netif_dbg(tp, probe, tp->netdev,
 				  "Invalid variant for MAC pass through\n");
 			return -ENODEV;
-- 
2.19.1




More information about the kernel-team mailing list