NACK/cmnt: [SRU][B/OEM][PATCH 0/1] Fix ACPI bug that causes boot failure

[Kai Heng Feng]

> On Mar 13, 2019, at 10:43 PM, Aaron Ma <aaron.ma at canonical.com> wrote:
> 
> BugLink: https://bugs.launchpad.net/bugs/1819921
> 
> [Impact]
> Some systems boot failed at a very early stage, only blackscreen shown.
> 
> [Fix]
> Some system BIOS set definition in if statement, it would be deferred to be loaded.
> Some devices would not work properly and cause a system lockup.
> execute all acpi tables to make system work properly.
> 
> [Test]
> Tested on several laptops, the laptop that failed to boot boots well.
> Other laptops still works fine.
> 
> [Regression Potential]
> Upstream fix. Low risk.
> Backported changes is one line of debug ouput sentence in nsparse.c:
> s/Start table execution pass/Start load pass/

Use MLC as default is a substantial change.

As of now, at least two patches fix this commit:

$ git log | egrep "Fixes.*5a8361f7" | wc -l
2

So a SAUCE patch follows approach in commit 36904703aeee
("ACPI / bus: Parse tables as term_list for Dell XPS 9570 and Precision M5530”)
would be better.
It can target specific model to minimize regression potential.

Kai-Heng

> 
> Verified on several laptops. Fix boot failure and no regression found.
> 
> This patch is from 4.17-rc1, so only Bionic/OEM 4.15 kernels need it.
> 
> Schmauss, Erik (1):
>  ACPICA: Integrate package handling with module-level code
> 
> drivers/acpi/acpica/dspkginit.c | 128 ++++++++++++++++++--------------
> drivers/acpi/acpica/dswexec.c   |   6 +-
> drivers/acpi/acpica/nsparse.c   |   4 +-
> drivers/acpi/acpica/pstree.c    |   1 +
> include/acpi/acpixf.h           |   8 +-
> 5 files changed, 85 insertions(+), 62 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team