ACK/cmnt: [SRU] [B/C] [PATCH 0/1] Allow userspace to change tun's carrier state

Kleber Souza kleber.souza at canonical.com
Thu Mar 7 17:59:21 UTC 2019


On 3/6/19 7:00 PM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1806392
>
> [Impact]
> Userspace cannot change tun's carrier state.
>
> [Fix]
> Add .ndo_change_carrier callback for tun.
>
> [Test]
> User confirm the backport works.
>
> [Regression Potential]
> Low. It add a new function and a new case switch for ioctl, but the new
> code doesn't affect existing behavior.
>
> Nicolas Dichtel (1):
>   tun: implement carrier change
>
>  drivers/net/tun.c           | 27 ++++++++++++++++++++++++++-
>  include/uapi/linux/if_tun.h |  1 +
>  2 files changed, 27 insertions(+), 1 deletion(-)
>

Fixed the nominations on the bug report, adding Bionic and Cosmic.
This patch is included on v5.0, so I have marked the development
status as invalid. Feel free to change it if you disagree.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>




More information about the kernel-team mailing list