APPLIED[Unstable]/cmt: [PATCH][SRU][X/B/C/D/E] mm/page_idle.c: fix oops because end_pfn is larger than max_pfn

Colin Ian King colin.king at canonical.com
Thu Jun 27 19:32:51 UTC 2019


On 27/06/2019 20:10, Seth Forshee wrote:
> On Wed, Jun 19, 2019 at 02:30:32PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1833410
>>
>> Currently the calcuation of end_pfn can round up the pfn number to more
>> than the actual maximum number of pfns, causing an Oops.  Fix this by
>> ensuring end_pfn is never more than max_pfn.
>>
>> This can be easily triggered when on systems where the end_pfn gets
>> rounded up to more than max_pfn using the idle-page stress-ng stress test:
>>
>> sudo stress-ng --idle-page 0
>>
>> [ 3812.222790] BUG: unable to handle kernel paging request at 00000000000020d8
>> [ 3812.224341] #PF error: [normal kernel read fault]
>> [ 3812.225144] PGD 0 P4D 0
>> [ 3812.225626] Oops: 0000 [#1] SMP PTI
>> [ 3812.226264] CPU: 1 PID: 11039 Comm: stress-ng-idle- Not tainted 5.0.0-5-generic #6-Ubuntu
>> [ 3812.227643] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
>> [ 3812.229286] RIP: 0010:page_idle_get_page+0xc8/0x1a0
>> [ 3812.230173] Code: 0f b1 0a 75 7d 48 8b 03 48 89 c2 48 c1 e8 33 83 e0 07 48 c1 ea 36 48 8d 0c 40 4c 8d 24 88 49 c1 e4 07 4c 03 24 d5 00 89 c3 be <49> 8b 44 24 58 48 8d b8 80 a1 02 00 e8 07 d5 77 00 48 8b 53 08 48
>> [ 3812.234641] RSP: 0018:ffffafd7c672fde8 EFLAGS: 00010202
>> [ 3812.235792] RAX: 0000000000000005 RBX: ffffe36341fff700 RCX: 000000000000000f
>> [ 3812.237739] RDX: 0000000000000284 RSI: 0000000000000275 RDI: 0000000001fff700
>> [ 3812.239225] RBP: ffffafd7c672fe00 R08: ffffa0bc34056410 R09: 0000000000000276
>> [ 3812.241027] R10: ffffa0bc754e9b40 R11: ffffa0bc330f6400 R12: 0000000000002080
>> [ 3812.242555] R13: ffffe36341fff700 R14: 0000000000080000 R15: ffffa0bc330f6400
>> [ 3812.244073] FS: 00007f0ec1ea5740(0000) GS:ffffa0bc7db00000(0000) knlGS:0000000000000000
>> [ 3812.245968] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> [ 3812.247162] CR2: 00000000000020d8 CR3: 0000000077d68000 CR4: 00000000000006e0
>> [ 3812.249045] Call Trace:
>> [ 3812.249625] page_idle_bitmap_write+0x8c/0x140
>> [ 3812.250567] sysfs_kf_bin_write+0x5c/0x70
>> [ 3812.251406] kernfs_fop_write+0x12e/0x1b0
>> [ 3812.252282] __vfs_write+0x1b/0x40
>> [ 3812.253002] vfs_write+0xab/0x1b0
>> [ 3812.253941] ksys_write+0x55/0xc0
>> [ 3812.254660] __x64_sys_write+0x1a/0x20
>> [ 3812.255446] do_syscall_64+0x5a/0x110
>> [ 3812.256254] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>
>> Link: http://lkml.kernel.org/r/20190618124352.28307-1-colin.king@canonical.com
>> Fixes: 33c3fc71c8cf ("mm: introduce idle page tracking")
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>

^^^^^^^^^^^^

>> (cherry picked from commit d96d6145d9796d5f1eac242538d45559e9a23404 linux-next)
>> Reviewed-by: Andrew Morton <akpm at linux-foundation.org>
>> Acked-by: Vladimir Davydov <vdavydov.dev at gmail.com>
>> Cc: Michal Hocko <mhocko at suse.com>
>> Cc: Mike Rapoport <rppt at linux.vnet.ibm.com>
>> Cc: Mel Gorman <mgorman at techsingularity.net>
>> Cc: Stephen Rothwell <sfr at canb.auug.org.au>
>> Cc: Andrey Ryabinin <aryabinin at virtuozzo.com>
>> Cc: <stable at vger.kernel.org>
>> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
>> Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>
> 
> Note to whoever applies this to the other trees, cking's sign-off is
> missing.

I have a sign-off, see above.

Colin

> 
> Applied to unstable/master with the sign-off added, thanks!
> 




More information about the kernel-team mailing list