ACK/cmt / APPLIED[Unstable]: [PATCH v2 0/1][D][OEM-OSP1-B]Sometimes touchpad automatically trigger double click

Seth Forshee seth.forshee at canonical.com
Thu Jun 27 19:22:17 UTC 2019


On Thu, Jun 20, 2019 at 01:06:58PM +0800, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1833484
> 
> [Impact]
> Dell machines which uses goodix touchpad IC emit double click event
> while touching the touchpad if designware i2c adapter is in runtime
> suspend.
> 
> Goodix re-assert the interrupt if host doesn't read the data within
> 100ms and designware takes a longer time to wake up from runtime
> suspend. In the case, it got a second interrupt during resuming, so
> it thinks it's a double click.
> 
> [Fix]
> There is no simple way to fix this, it's a firmware issue and goodix
> agrees to fix this in their firmware on next release, but this issue is
> still affects the machines that don't come with an updated firmware. So,
> add a quirk to mark those machines and avoid the designware from entering
> runtime suspend.
> 
> [Regression Potential]
> Low, it only affects the listed machines, and prevent designware from
> entering runtime suspend impacts the power consumption little or none
> during short or long idle.
> 
> [MISC]
> This patch contains on going product name, so set it as SAUCE patch,
> will submit it to upstream and to Bionic kernel later.

I find the implementation kind of clumsy, but it keeps the patch simpler
than it might otherwise be. Limited to specific hardware so regression
potential is low:

Acked-by: Seth Forshee <seth.forshee at canonical.com>

Please remember to include unstable when necessary! Applied to
unstable/master, thanks.



More information about the kernel-team mailing list