[SRU][Xenial][PATCH 0/1] geneve: correctly handle ipv6.disable module parameter

Nivedita Singhvi nivedita.singhvi at canonical.com
Wed Jun 26 09:28:43 UTC 2019


BugLink: https://bugs.launchpad.net/bugs/1794232

SRU Justification

Impact: Cannot create geneve tunnels if ipv6 is disabled dynamically.

Fix:
Fixed by upstream commit in v5.0:
Commit: cf1c9ccba7308e48a68fa77f476287d9d614e4c7
"geneve: correctly handle ipv6.disable module parameter"

Hence available in Disco and later; required in X,B,C.

(Note: B, C completed separately, this is for X only.)

Testcase:
1. Boot with "ipv6.disable=1"
2. Then try and create a geneve tunnel using:
   # ovs-vsctl add-br br1
   # ovs-vsctl add-port br1 geneve1 -- set interface geneve1
    type=geneve options:remote_ip=192.168.x.z // ip of the other host


Regression Potential: Low, only geneve tunnels when ipv6 dynamically
disabled, current status is it doesn't work at all.


Other Info:
* This fix was previously cherry-picked and SRU'd in B, C. The 
  Bionic, Cosmic kernels with the fix were released. Patch applied 
  cleanly there.

* This backported patch to be applied only to Xenial.

  Backport change: The check for ipv6 family retained the original
  geneve->remote.sa.sa_family == AF_INET6 code as "geneve->info.mode 
  & IP_TUNNEL_INFO_IPV6" check needs infrastructure not yet available.

* Mainline commit msg includes reference to a fix for non-metadata 
  tunnels (infrastructure is not yet in our tree prior to Disco), 
  hence not being included at this time under this case.

  At this time, all geneve tunnels created as above are 
  metadata-enabled.



Jiri Benc (1):
  geneve: correctly handle ipv6.disable module parameter

 drivers/net/geneve.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list