ACK/cmt / APPLIED[Unstable]: [PATCH][Unstable][SRU Disco][SRU Cosmic][SRU Bionic] hinic: fix a bug in set rx mode

[dann frazier]

On Tue, Jun 18, 2019 at 8:59 AM Seth Forshee <seth.forshee at canonical.com> wrote:
>
> On Mon, Jun 17, 2019 at 06:26:07PM -0600, dann frazier wrote:
> > From: Xue Chaojing <xuechaojing at huawei.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/1832048
> >
> > in set_rx_mode, __dev_mc_sync and netdev_for_each_mc_addr will
> > repeatedly set the multicast mac address. so we delete this loop.
> >
> > Signed-off-by: Xue Chaojing <xuechaojing at huawei.com>
> > Signed-off-by: David S. Miller <davem at davemloft.net>
> > (cherry picked from commit 66350023d57560b2ead168af098fc507e58d8e6a linux-next)
> > Signed-off-by: dann frazier <dann.frazier at canonical.com>
>
> No fault of yours, but the patch description is not all that helpful.

I agree. I tried to clarify this on list, in the hopes that it'd get
flagged as a fix for 5.2 & stable:
  https://www.spinics.net/lists/netdev/msg576962.html
  https://www.spinics.net/lists/netdev/msg576971.html

> Assuming that you've verified the fix using the test case on the bug
> (I'm petty confident you have, just want to be certain):

I haven't been able to trigger the bug myself. I left a couple systems
in a rmmod/modprobe loop over night w/o a hit. But, Huawei tells me it
is just very difficult to hit. My testing w/ the patch was therefore
just verification that things still worked as before.

  -dann