ACK/APPLIED: [PATCH 0/1][SRU][Disco] shiftfs: allow changing ro/rw for

Seth Forshee seth.forshee at canonical.com
Fri Jun 14 20:33:23 UTC 2019


On Tue, Jun 11, 2019 at 11:47:34AM +0200, Christian Brauner wrote:
> https://bugs.launchpad.net/bugs/1832316
> 
> SRU Justification
> 
> Impact: Stéphane reported regression for btrfs workloads employing shiftfs.
> Unprivileged users can already toggle whether a subvolume will be ro or
> rw. This is broken on current shiftfs as we haven't whitelisted these
> ioctls().
> 
> Fix: To enable this with shiftfs we need to whitelist BTRFS_IOC_FS_INFO,
> BTRFS_IOC_SUBVOL_GETFLAGS, BTRFS_IOC_SUBVOL_SETFLAGS. All of them should
> be safe for unprivileged users.
> 
> Regression Potential: Limited to shiftfs.
> 
> Test Case: Tested with LXD running shiftfs on top of btrfs and verified
> btrfs subvolumes can be made ro or rw.

Seems as okay as the rest of this btrfs ioctl stuff, with positive
testing.

Acked-by: Seth Forshee <seth.forshee at canonical.com>

Applied to unstable/master, thanks!



More information about the kernel-team mailing list