ACK/Cmnt: [SRU][B/C/D][PATCH 0/2] ALSA: hda/realtek - Headset fixup for System76 Gazelle (gaze14)

[Connor Kuehl]

On 6/5/19 10:54 AM, Connor Kuehl wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827555
> 
> [Impact]
> 
>  * On the System76 Gazelle (gaze14), there is a headset microphone input 
>  attached to 0x1a that does not have a jack detect. In order to get it 
>  working, the pin configuration needs to be set correctly, and the 
>  ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is
>  identical to the patch already applied for the System76 Darter Pro (darp5).
> 
> [Test Case]
> 
>  * With the affected hardware, attempt to use a headset with a microphone input.
>  There will be no microphone input from the headset until applying this patch.
> 
> [Regression Potential]
> 
>  * Extremely low, it specifically identifies the affected hardware.
> 
> Jeremy Soller (2):
>   ALSA: hda/realtek - Headset fixup for System76 Gazelle (gaze14)
>   ALSA: hda/realtek - Corrected fixup for System76 Gazelle (gaze14)
> 
>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 

I know this cover letter comes from me, but these e-mails were generated
as a consequence of me bundling Jeremy's commits into one e-mail chain
with some SRU paperwork git-message modifications... Jeremy's changes
themselves that we see here look good to me.

Just as an aside, when I tried applying these to Bionic and Cosmic, "git
am" would error even with a 3-way merge as it was unable to "fake an
ancestor" this might just be because of how we rebase our trees? I
haven't looked too far into it yet, but these applied cleanly when I
cherry-picked from my local disco repo after applying them there...

Acked-by: Connor Kuehl <connor.kuehl at canonical.com>

-- 
Connor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 5950 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190605/82295a5c/attachment-0001.key>