APPLIED: [SRU][B][PATCH v2 0/1] zfs: fix potential build error

Kleber Souza kleber.souza at canonical.com
Mon Jun 3 14:32:06 UTC 2019


On 5/20/19 11:46 AM, Andrea Righi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1828763
> 
> [Impact]
> 
> * In b49151d684f44 tx_waited has been renamed to tx_dirty_delayed, but only in
>   the tracepoint definition (in trace_dmu.h) and not in the rest of the code,
>   causing build errors if zfs tracepoints are enabled.
> 
> * Fix by reverting tx_dirty_delayed back to the original name tx_waited
> 
> NOTE: this bug doesn't show up in regular kernel builds, because zfs
> tracepoints are not enabled by default, it is possible to see this problem only
> by enabling them and recompiling zfs outside our regular build process, but
> it's a good cleanup anyway (in case we need to enable zfs tracepoints in the
> future).
> 
> [Test Case]
> 
>  * enable zfs tracepoints in config and build zfs
> 
> [Fix]
> 
>  * Restore the old struct name to fix the build bug
> 
> [Regression Potential]
> 
>  * It is a very small fix (just a rename of a struct member), so regression
>    potential is minimal
> 
> Changes in v2:
>  - patch generated follownig the right workflow to apply zfs fixes and tested
>    (all autotest passed correctly)
> 
>  META                    |    2 +-
>  include/sys/trace_dmu.h |    6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> 

Applied to bionic/master-next branch.

Thanks,
Kleber



More information about the kernel-team mailing list