ACK/cmt / APPLIED[E/Unstable]: [SRU][B/OEM-B/D/E][PATCH 0/1] alsa/hda: neither mute led nor mic-mute led work on several Lenovo laptops

Seth Forshee seth.forshee at canonical.com
Mon Jul 29 17:37:26 UTC 2019


On Sat, Jul 27, 2019 at 09:00:04AM +0800, Hui Wang wrote:
> 
> On 2019/7/27 上午5:09, Seth Forshee wrote:
> > On Fri, Jul 26, 2019 at 11:54:53AM +0800, Hui Wang wrote:
> > > BugLink: http://bugs.launchpad.net/bugs/1837963
> > > 
> > > [Impact]
> > > We have a couple of lenovo laptops which have conexant codec, the mute/mic-mute
> > > doesn't work on these machines.
> > > 
> > > [Fix]
> > > Without this patch, the generic driver will be in use for this codec, generic
> > > driver doesn't apply any fixup for those machines, to let the led work, we need
> > > to apply fixup, so change the code to let patch_conexant.c drive hw.
> > > 
> > > [Test Case]
> > > After booting up, please mute/mic-mute hotkeys, the led can turn on/off.
> > > 
> > > [Regression Risk]
> > > Low. It is specific to the conexant codec with ID 1f86.
> > This is a patch from a maintainer tree and thus needs to be marked as
> > sauce. With that fixed:
> 
> Only eaon and unstable need sauce or all kernels need sauce? I remember in
> the past, if we didn' t need to add sauce when backporting the patches from
> maintainer's tree, since the patches will be merged to mainline tree soon
> with the same commit id.

Afaik the policy was always that you need it for cherry picks from
maintainer trees, but not for patches from linux-next. I'm sure it
hasn't always been consistently enforced though (I know I've slipped up
on enforcing it even recently).

Seth



More information about the kernel-team mailing list