ACK/cmt / APPLIED[E]: [SRU][B/OEM-B/D/OEM-OSP1-B/E][PATCH v2 0/2] input/mouse: alps trackpoint-only device doesn't work

Seth Forshee seth.forshee at canonical.com
Fri Jul 19 19:40:54 UTC 2019


On Fri, Jul 19, 2019 at 10:39:15PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836752
> 
> In the V2:
> I added one more patch (0002) to fix the problem of condition checking
> of 0x20~0x2f (apw found this problem in the v1)
> 
> Since the OEM-OSP1-B already merged 0001, it only needs to merge 0002
> this time, for the rest of kernel version, need to merge 0001 and 0002.
> 
> [Impact]
> On one of the latest Lenovo laptops, the trackpoint doesn't work, we
> consulted apls guys, they said this trackpoint is different from others,
> it is a trackpoint-only device, so the current alps.c doesn't support it
> well, while the trackpoint.c can drive it well.
> 
> [Fix]
> Check if it is trakcpoint-only device, if it yes, let trackpoint.c
> handle it.
> 
> [Test Case]
> apply this patch and boot with the kernel, the trackpoint can work
> well.
> 
> [Regression Risk]
> Low. the way of detect trackpoint-only alps device is provided by
> alps. so it is pretty safe. and I have tested the patch on two
> lenovo machines with alsp touchpad+trackpoint device, they worked
> well.

Patches from a maintainer tree are sauce patches. With the commit
description fixed to reflect this:

Acked-by: Seth Forshee <seth.forshee at canonical.com>

Applied to eoan/master-next, with the subject changed to add "UBUNTU:
SAUCE:", thanks!



More information about the kernel-team mailing list