[SRU][B/OEM-B/D/OEM-OSP1-B/E][PATCH v2 0/2] input/mouse: alps trackpoint-only device doesn't work

Hui Wang hui.wang at canonical.com
Fri Jul 19 14:39:15 UTC 2019

BugLink: https://bugs.launchpad.net/bugs/1836752

In the V2:
I added one more patch (0002) to fix the problem of condition checking
of 0x20~0x2f (apw found this problem in the v1)

Since the OEM-OSP1-B already merged 0001, it only needs to merge 0002
this time, for the rest of kernel version, need to merge 0001 and 0002.

On one of the latest Lenovo laptops, the trackpoint doesn't work, we
consulted apls guys, they said this trackpoint is different from others,
it is a trackpoint-only device, so the current alps.c doesn't support it
well, while the trackpoint.c can drive it well.

Check if it is trakcpoint-only device, if it yes, let trackpoint.c
handle it.

[Test Case]
apply this patch and boot with the kernel, the trackpoint can work

[Regression Risk]
Low. the way of detect trackpoint-only alps device is provided by
alps. so it is pretty safe. and I have tested the patch on two
lenovo machines with alsp touchpad+trackpoint device, they worked

Hui Wang (2):
  Input: alps - don't handle ALPS cs19 trackpoint-only device
  Input: alps - fix a mismatch between a condition check and its comment

 drivers/input/mouse/alps.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)


More information about the kernel-team mailing list