[SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Hui Wang hui.wang at canonical.com
Fri Jul 19 09:34:13 UTC 2019


On 2019/7/19 下午4:42, Stefan Bader wrote:
> On 17.07.19 16:42, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1836916
>>
>> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
>> our oem project is waiting for this patch.
>>
>> And Since this patch is to support icl hdmi audio and it depends on
>> i915 to support icl first, and our bionic and oem-b kernel doesn't
>> support icl in their i915 driver, so these patchset doesn't work for
>> B/OEM-B, as a result, I don't send them for B/OEM-B.
>>
>> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
>> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
>> to EAON kernel.
>>
>> [Impact]
>> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
>> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>>
>> [Fix]
>> add icl hdmi audio id and related support patch to alsa driver.
>>
>> [Test Case]
>> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
>> in the sound-setting and works well, after unplugging the cable, the hdmi
>> audio disappears as expected.
>>
>> [Regression Risk]
>> Low. this patchset is specific to a icl hdmi audio codec.
>>
>>
>>
>> Jaroslav Kysela (1):
>>    ALSA: hda: hdmi - add Icelake support
>>
>> Takashi Iwai (2):
>>    ALSA: hda/hdmi - Remove duplicated define
>>    ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>>
>>   sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>>   1 file changed, 69 insertions(+), 21 deletions(-)
>>
> With 2/3 of a set coming from subsystem maintainers tip and not fully buying
> into a low regression potential (it changes a driver which at least is shared
> across similar HW and Intel is not unknown to break older stuff when adding new
> stuff) I am wondering whether this really is Sru material...

Our OEM project needs this patchset, otherwise the hdmi audio doesn't 
work on Dell icl laptop.

The 0001 patch is specific to icl codec by adding the new codec id, and 
the 0003 has no change  for codec  with port_num==0, that means there is 
no change for non-icl codec after applying this patch.

If you think it is too early to merge these patches to generic kernel, 
it is fine to drop them. let the OEM-OSP1-B merge them first.

Thanks



>



More information about the kernel-team mailing list