ACK: [SRU B/D][Unstable][PATCH 1/1] ixgbevf: Use cached link state instead of re-reading the value for ethtool

[Stefan Bader]

On 16.07.19 22:13, Guilherme G. Piccoli wrote:
> From: Alexander Duyck <alexander.h.duyck at linux.intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1836760
> 
> Change the ethtool link settings call to just read the cached state out of
> the adapter structure instead of trying to recheck the value from the PF.
> Doing this should prevent excessive reading of the mailbox.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck at linux.intel.com>
> Reviewed-by: "Guilherme G. Piccoli" <gpiccoli at canonical.com>
> Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>
> (cherry picked from commit 1e1b0c658d9bb364b4a2a4b08a760d3e4c239bdc)
> Signed-off-by: Guilherme G. Piccoli <gpiccoli at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ethtool.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> index 5399787e07af..54459b69c948 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> @@ -85,22 +85,16 @@ static int ixgbevf_get_link_ksettings(struct net_device *netdev,
>  				      struct ethtool_link_ksettings *cmd)
>  {
>  	struct ixgbevf_adapter *adapter = netdev_priv(netdev);
> -	struct ixgbe_hw *hw = &adapter->hw;
> -	u32 link_speed = 0;
> -	bool link_up;
>  
>  	ethtool_link_ksettings_zero_link_mode(cmd, supported);
>  	ethtool_link_ksettings_add_link_mode(cmd, supported, 10000baseT_Full);
>  	cmd->base.autoneg = AUTONEG_DISABLE;
>  	cmd->base.port = -1;
>  
> -	hw->mac.get_link_status = 1;
> -	hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
> -
> -	if (link_up) {
> +	if (adapter->link_up) {
>  		__u32 speed = SPEED_10000;
>  
> -		switch (link_speed) {
> +		switch (adapter->link_speed) {
>  		case IXGBE_LINK_SPEED_10GB_FULL:
>  			speed = SPEED_10000;
>  			break;
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190719/9f21adc1/attachment-0001.sig>