[SRU][B/C/D/OEM-OSP1-B/E][PATCH 0/1] input/mouse: alps trackpoint-only device doesn't work

[Hui Wang]

On 2019/7/18 上午12:56, Seth Forshee wrote:
> On Tue, Jul 16, 2019 at 10:12:56PM +0800, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1836752
>>
>> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
>> our oem project is waiting for this patch.
>>
>> [Impact]
>> On one of the latest Lenovo laptops, the trackpoint doesn't work, we
>> consulted apls guys, they said this trackpoint is different from others,
>> it is a trackpoint-only device, so the current alps.c doesn't support it
>> well, while the trackpoint.c can drive it well.
>>
>> [Fix]
>> Check if it is trakcpoint-only device, if it yes, let trackpoint.c
>> handle it.
>>
>> [Test Case]
>> apply this patch and boot with the kernel, the trackpoint can work
>> well.
>>
>> [Regression Risk]
>> Low. the way of detect trackpoint-only alps device is provided by
>> alps. so it is pretty safe.
> You assert that it is safe because the method was provided by alps, but
> I'd also like to know that regression testing has been done with at
> least some other alps hardware. Has any such testing been done?

Yes, I already tested the patch on two other Lenovo machines, all of 
these two machines have alps touchpad+trackpoint design, and this patch 
does not break their support.

Thanks

>