NAK/cmnt - Re: [D][E][SRU][PATCH 1/1] UBUNTU: [Config] Enable CONFIG_MVPP2 for arm64
po-hsu.lin at canonical.com
Mon Jul 15 06:56:58 UTC 2019
Thanks for the feedback,
I will send V2 for this.
On Tue, Jul 9, 2019 at 9:59 PM Paolo Pisati <paolo.pisati at canonical.com> wrote:
> On Tue, Jul 09, 2019 at 04:19:58PM +0800, Po-Hsu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1835054
> > Enable the CONFIG_MVPP2 for arm64. This is a driver for network
> > controllers(s) in Marvell SOCs, particularly Armada 8040.
> > Corresponding configs like CONFIG_ARCH_MVEBU and CONFIG_ARCH_MULTI_V7
> > need to be enabled as well to meet the dependency requirement.
> > CONFIG_CRYPTO_DEV_SAFEXCEL and CONFIG_PCI_AARDVARK are disabled
> > explicitly to avoid interactive dialogues when building the kernel.
> ARCH_MULTI_V7 has nothing to do with arm64 (is an arm32-only symbol), drop it.
> And the bug is misleading: the MVPP2 driver is already enabled in our kernel
> (see debian.master/config/config.common.ubuntu:CONFIG_MVPP2=m), but since it
> dependes on ARCH_MVEBU=y, it doesn't get compiled for arm64.
> Thus to make it build, you enable the Armada SOCs (ARCH_MVEBU=y) in our generic
> arm64 kernel too (not that i'm against it) - i would rename the bug something
> like "Enable Armada SOCs in disco/generic arm64".
> And don't forget to run updateconfigs after enabling a new arch, since many
> new options will automatically turn on.
More information about the kernel-team