CMNT Re: [SRU] [B/D/Unstable/OEM-B/OEM-OSP1-B] [PATCH 0/2] Fix RX CRC errors on I219 v6

[Anthony Wong]

On Thu, 11 Jul 2019 at 16:16, Timo Aaltonen <tjaalton at ubuntu.com> wrote:
>
> On 11.7.2019 10.47, Kai-Heng Feng wrote:
> > at 15:35, Timo Aaltonen <tjaalton at ubuntu.com> wrote:
> >
> >> On 11.7.2019 10.16, Kai-Heng Feng wrote:
> >>> BugLink: https://bugs.launchpad.net/bugs/1836152
> >>>
> >>> [Impact]
> >>> RX speed on Intel ethernet I219 v6 is extremely slow due to multiple RX
> >>> CRC errors.
> >>>
> >>> [Fix]
> >>> Disable e1000e K1 feature to make I219 and PCH operate at higher speed
> >>> to avoid the issue.
> >>>
> >>> [Test]
> >>> Before applying the patch, the RX is slower than 150Kbps. After applying
> >>> the fix the RX speed can achive gigabits.
> >>>
> >>> [Regression Potential]
> >>> Low. This only applies to recent I219 generations.
> >>> I've also test several other systems with e1000e and I don't see any
> >>> regression.
> >>
> >> Hi, any idea why these were never applied upstream?
> >
> > Well, because it just landed to Intel ethernet tree, it will be applied
> > to mainline eventually.
>
> So it just took over 2,5y to land upstream? That's impressive :)

Intel has been maintaining an out-of-tree e1000e driver for almost 3
years, and they don't bother to close the gap between that and
mainline until recently.
There is no public git tree for that out-of-tree driver so we couldn't
bisect the issue, we are lucky to discover these patches for DPDK that
can be applied to mainline's driver, and so we submitted them back and
got accepted.

Thanks,
Anthony