NACK/Cmnt: [SRU] [B] [PATCH 0/8] Backport ACPI module-level code functionality

[Stefan Bader]

On 10.07.19 10:52, Kai Heng Feng wrote:
> at 3:52 PM, Stefan Bader <stefan.bader at canonical.com> wrote:
> 
>> On 04.07.19 06:50, Kai-Heng Feng wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1835357
>>>
>>> [Impact]
>>> After S3, DVD-ROM on HP ZBook 17 G5 stops working.
>>>
>>> [Fix]
>>> In the past we use dmi_match to set acpi_gbl_parse_table_as_term_list,
>>> so the ACPI core can parse an entire ACPI table as a method.
>>>
>>> Unfotunately this workaround doesn't work for the system in question.
>>>
>>> So fully backport commit 5a8361f7ecce ("ACPICA: Integrate package
>>> handling with module-level code") and subsequent fix commits, to solve
>>> the issue.
>>>
>>> [Test]
>>> After applying the fix, DVD-ROM keeps working after S3.
>>>
>>> [Regression Potential]
>>> Medium. I've test several systems and I don't see anything break.
>>> But if we want to be safe, we can merge this into Bionic after we are
>>> sure there's no regression on OEM-B.
>>>
>>> Bob Moore (2):
>>>   ACPICA: Cleanup/simplify module-level code support
>>>   ACPICA: Add deferred package support for the Load and loadTable
>>>     operators
>>>
>>> Erik Schmauss (2):
>>>   ACPICA: Remove acpi_gbl_group_module_level_code and only use
>>>     acpi_gbl_execute_tables_as_methods instead
>>>   ACPI: probe ECDT before loading AML tables regardless of module-level
>>>     code flag
>>>
>>> Kai-Heng Feng (2):
>>>   Revert "UBUNTU: SAUCE: ACPI / bus: Add some Lenovo laptops in list of
>>>     acpi table term list"
>>>   Revert "ACPI / bus: Parse tables as term_list for Dell XPS 9570 and
>>>     Precision M5530"
>>>
>>> Rafael J. Wysocki (1):
>>>   ACPI: EC: Look for ECDT EC after calling acpi_load_tables()
>>>
>>> Schmauss, Erik (1):
>>>   ACPICA: Integrate package handling with module-level code
>>>
>>>  drivers/acpi/acpica/acnamesp.h  |   4 +
>>>  drivers/acpi/acpica/dspkginit.c | 128 ++++++++++++++++++--------------
>>>  drivers/acpi/acpica/dswexec.c   |   6 +-
>>>  drivers/acpi/acpica/evrgnini.c  |   3 +
>>>  drivers/acpi/acpica/exconfig.c  |  14 ++++
>>>  drivers/acpi/acpica/nseval.c    |  14 ++++
>>>  drivers/acpi/acpica/nsinit.c    |  71 ++++++++++++++----
>>>  drivers/acpi/acpica/nsload.c    |  24 +++---
>>>  drivers/acpi/acpica/nsparse.c   |  24 +++++-
>>>  drivers/acpi/acpica/psloop.c    |  24 +++++-
>>>  drivers/acpi/acpica/pstree.c    |   1 +
>>>  drivers/acpi/acpica/tbdata.c    |  18 +++--
>>>  drivers/acpi/acpica/tbxfload.c  |  14 ++--
>>>  drivers/acpi/acpica/utxfinit.c  |  48 +++++-------
>>>  drivers/acpi/bus.c              | 114 ++++++----------------------
>>>  include/acpi/acpixf.h           |   9 +--
>>>  include/acpi/actypes.h          |  20 ++---
>>>  17 files changed, 292 insertions(+), 244 deletions(-)
>> After talking on IRC, I do not think the risk of that change (and my experience
>> is that one can hardly do any change with ACPI(CA) that does not have some
>> unexpected side-effect) is not gaining enough on the other side. Rather than
>> modifying the whole environment this should be fixed minimally (especially when
>> this was introduced by a SAUCE patch).
> 
> Actually this SRU is to fix this issue:
> "After S3, DVD-ROM on HP ZBook 17 G5 stops working"
> 
> It just happen to solve the Xen PVH issue by reverting "UBUNTU: SAUCE: ACPI /
> bus: Add some Lenovo laptops in list of acpi table term list”.

Hm, ok. Still it fixes a CDROM surviving S3 by reworking ACPI/-CA quite a bit.
And the fact that some change done to that subsystem broke Xen in some way does
add to my reservations to pull in even more changes.

-Stefan
> 
> Kai-Heng
> 
>>
>> -Stefan
>>
>> -- 
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190710/13eade89/attachment-0001.sig>